-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract disk operations for different disk drivers #105
Merged
+1,221
−387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbit
force-pushed
the
disk-driver
branch
23 times, most recently
from
February 5, 2024 14:58
8bfb42e
to
3ac08fe
Compare
derekbit
force-pushed
the
disk-driver
branch
6 times, most recently
from
February 7, 2024 09:16
d613bab
to
25a78ba
Compare
ping @innobead |
This pull request is now in conflict. Could you fix it @derekbit? 🙏 |
Longhorn 7985 Signed-off-by: Derek Su <[email protected]>
DamiaSan
previously approved these changes
Mar 27, 2024
shuo-wu
reviewed
Mar 28, 2024
derekbit
force-pushed
the
disk-driver
branch
2 times, most recently
from
March 28, 2024 05:50
cd1e4e3
to
b0a92d4
Compare
derekbit
force-pushed
the
disk-driver
branch
2 times, most recently
from
March 29, 2024 02:23
ddb9e40
to
a6b6d9a
Compare
shuo-wu
previously approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM
Longhorn 7672 Signed-off-by: Derek Su <[email protected]>
Longhorn 7672 Signed-off-by: Derek Su <[email protected]>
Longhorn 7672 Signed-off-by: Derek Su <[email protected]>
Longhorn 7672 Signed-off-by: Derek Su <[email protected]>
Longhorn 7672 Signed-off-by: Derek Su <[email protected]>
DamiaSan
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#7672
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context
Deps on longhorn/go-spdk-helper#72