Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract disk operations for different disk drivers #105

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

derekbit
Copy link
Member

@derekbit derekbit commented Jan 29, 2024

Which issue(s) this PR fixes:

Issue longhorn/longhorn#7672

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

Deps on longhorn/go-spdk-helper#72

@derekbit derekbit self-assigned this Jan 29, 2024
@derekbit derekbit force-pushed the disk-driver branch 23 times, most recently from 8bfb42e to 3ac08fe Compare February 5, 2024 14:58
@derekbit derekbit force-pushed the disk-driver branch 6 times, most recently from d613bab to 25a78ba Compare February 7, 2024 09:16
@derekbit
Copy link
Member Author

ping @innobead

Copy link

mergify bot commented Mar 27, 2024

This pull request is now in conflict. Could you fix it @derekbit? 🙏

DamiaSan
DamiaSan previously approved these changes Mar 27, 2024
pkg/spdk/disk/types.go Outdated Show resolved Hide resolved
pkg/spdk/disk/types.go Show resolved Hide resolved
pkg/spdk/disk/types.go Outdated Show resolved Hide resolved
pkg/spdk/disk/types.go Outdated Show resolved Hide resolved
pkg/spdk/disk/driver.go Outdated Show resolved Hide resolved
pkg/spdk/disk/driver.go Show resolved Hide resolved
pkg/util/block.go Outdated Show resolved Hide resolved
pkg/spdk/disk/aio/aio.go Outdated Show resolved Hide resolved
@derekbit derekbit force-pushed the disk-driver branch 2 times, most recently from cd1e4e3 to b0a92d4 Compare March 28, 2024 05:50
@derekbit derekbit requested review from DamiaSan and shuo-wu March 28, 2024 07:22
@derekbit derekbit force-pushed the disk-driver branch 2 times, most recently from ddb9e40 to a6b6d9a Compare March 29, 2024 02:23
shuo-wu
shuo-wu previously approved these changes Mar 29, 2024
Copy link
Contributor

@shuo-wu shuo-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM

@derekbit derekbit enabled auto-merge (rebase) March 29, 2024 06:56
@derekbit derekbit disabled auto-merge March 29, 2024 06:56
@derekbit derekbit requested a review from shuo-wu March 29, 2024 07:32
Longhorn 7672

Signed-off-by: Derek Su <[email protected]>
Longhorn 7672

Signed-off-by: Derek Su <[email protected]>
Longhorn 7672

Signed-off-by: Derek Su <[email protected]>
Longhorn 7672

Signed-off-by: Derek Su <[email protected]>
@derekbit derekbit merged commit 8326ea0 into longhorn:main Mar 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants